Skip to content

Fix for Issue 1179 + code cleanup #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeffriley merged 8 commits into from
Aug 25, 2024
Merged

Fix for Issue 1179 + code cleanup #1194

jeffriley merged 8 commits into from
Aug 25, 2024

Conversation

@jeffriley
Copy link
Collaborator

@jeffriley jeffriley commented Aug 23, 2024

  • Remove unsupported option value (FIXED) for options PULSAR_BIRTH_SPIN_PERIOD_DISTRIBUTION and PULSAR_BIRTH_MAGNETIC_FIELD_DISTRIBUTION

  • Remove BeBinary-related code (mostly already commented)

jeffriley and others added 2 commits August 23, 2024 10:42
@jeffriley
Fix for issue #1179: Remove unsupported option value (FIXED) for opti…
c78ca29 
…ons PULSAR_BIRTH_SPIN_PERIOD_DISTRIBUTION and PULSAR_BIRTH_MAGNETIC_FIELD_DISTRIBUTION

- Remove BeBinary-related code (mostly already commented)
@jeffriley
Merge pull request #1193 from jeffriley/issue-1179
48f0abe 
Fix for issue #1179
@jeffriley jeffriley added bug Something isn't working severity_minor This bug is not very severe urgency_low This issue is not urgent code cleanup/optimisation labels Aug 23, 2024
@jeffriley jeffriley requested a review from ilyamandel August 23, 2024 16:45
@jeffriley jeffriley linked an issue Aug 23, 2024 that may be closed by this pull request
Unsupported option PULSAR_BIRTH_SPIN_PERIOD_DISTRIBUTION::FIXED #1179
Closed
@jeffriley jeffriley mentioned this pull request Aug 23, 2024
Closed
@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

badge

Build Successful! You can find a link to the downloadable artifact below.

Name Link
Commit fc43376
Logs https://github.com/TeamCOMPAS/COMPAS/actions/runs/10543622457
Download https://github.com/TeamCOMPAS/COMPAS/suites/$SUITE_ID/artifacts/$ARTIFACT_ID

ilyamandel
ilyamandel requested changes Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jeffriley !

The one change request is for documentation:
https://compas.readthedocs.io/en/latest/pages/User%20guide/Program%20options/program-options-list-defaults.html#options-props-p
should be updated to no longer advertise FIXED for the two distributions you mentioned.

However, I'd really like to roll in #1080 first, since @Adam-Boesky is about to go offline -- so could you please check that one (it's waiting on you since you have a change request)?

@yuzhesong -- flagging this one for your attention, no need to include this in #1082 as we discussed on Slack earlier.

ilyamandel
ilyamandel approved these changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jeffriley -- looks good!

@jeffriley
Merge pull request #1201 from jeffriley/issue-1179
fc43376 
Updated Options.cpp, Options.h
@jeffriley jeffriley merged commit eab3579 into dev Aug 25, 2024
@jeffriley jeffriley deleted the issue-1179 branch August 25, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyamandel ilyamandel ilyamandel approved these changes

Assignees

No one assigned

Labels

bug Something isn't working code cleanup/optimisation severity_minor This bug is not very severe urgency_low This issue is not urgent

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unsupported option PULSAR_BIRTH_SPIN_PERIOD_DISTRIBUTION::FIXED

3 participants

@jeffriley @ilyamandel